Open
Conversation
yiyixuxu
approved these changes
Mar 25, 2026
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
I left one feedback
looking great!
dg845
reviewed
Mar 26, 2026
sayakpaul
reviewed
Mar 26, 2026
| - Support `generator` parameter for reproducibility | ||
| - Use `self.progress_bar(timesteps)` for progress tracking | ||
|
|
||
| ## Gotchas |
.ai/models.md
Outdated
| ## Common diffusers conventions | ||
|
|
||
| - Models use `ModelMixin` with `register_to_config` for config serialization | ||
| - Pipelines inherit from `DiffusionPipeline` |
Member
There was a problem hiding this comment.
It's not a model thing, though.
Member
Author
There was a problem hiding this comment.
lmk what you think of this:
- rename to
## Common model conventionsand only keep the model relevant convention - move these conventions under a new
### Pipelines & Schedulerssection inAGENTS.md(we could also create a newpipeline-scheduler.mdfile if you prefer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #13297:
models.md, a shared reference for holding model coding style, dependencies, common conventions, attention patterns, gotchas, etc.AGENTS.md,model-integration/SKILL.md, andreview-rules.mdto point to newmodels.md