Add support for logging extra columns in reward functions and update related tests#5308
Merged
qgallouedec merged 6 commits intomainfrom Apr 4, 2026
Merged
Add support for logging extra columns in reward functions and update related tests#5308qgallouedec merged 6 commits intomainfrom
qgallouedec merged 6 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 678d96dfa5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
This PR is a minor thing and didn't get reviewed after 2 weeks, I'll go ahead and merge, feel free to suggest modification in subsequent PR is needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the
log_extrakwargs (added in #5233, cc @manueldeprada) in TRL's built-in reward functions, and add the console table to display extra columns.Changes
accuracy_reward: logssolution,gold_parsed, andanswer_parsedvialog_extrareasoning_accuracy_reward: same extra columns, plus"[incomplete reasoning]"sentinel for completions missing the reasoning delimiter.All new parameters default to
Noneso the functions can still be called directly outside a trainer (e.g., in tests).Note
Low Risk
Low risk: changes are limited to logging/diagnostic paths and optional parameters, with minimal impact on training logic aside from additional metadata collection.
Overview
Adds support for displaying arbitrary extra per-completion metadata in the rich console completions table via a new
extraargument toprint_prompt_completions_sample, including subsampling behavior.Extends
accuracy_rewardandreasoning_accuracy_rewardto accept an optionallog_extracallback and emitsolution,gold_parsed, andanswer_parsed(with sentinel values for unparseable/skipped/incomplete reasoning cases) for trainer logging.Updates
GRPOTrainerandRLOOTrainerto pass their collectedextralogs into the console printer, and adds/updates tests to validate the new extra-column table output.Reviewed by Cursor Bugbot for commit 69daa80. Bugbot is set up for automated code reviews on this repo. Configure here.