fix(auth): bypass authentication for CORS preflight requests#358
Open
fGeorjje wants to merge 1 commit intohyperblast:masterfrom
Open
fix(auth): bypass authentication for CORS preflight requests#358fGeorjje wants to merge 1 commit intohyperblast:masterfrom
fGeorjje wants to merge 1 commit intohyperblast:masterfrom
Conversation
- Allow OPTIONS requests to skip authentication, as browsers are forbidden from sending credentials during a preflight handshake. - Move ResponseHeadersFilter before BasicAuthFilter to ensure CORS headers are attached to the response even if authentication fails. This ensures that browser-based clients can successfully authenticate with the server without being blocked by CORS preflight failures. Fixes hyperblast#357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that browser-based clients can successfully authenticate with the server without being blocked by CORS preflight failures.
Fixes #357