build(deps): use tpm2-tss version 4.1.3 instead of nightly#28
build(deps): use tpm2-tss version 4.1.3 instead of nightly#28hyperfinitism merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the tpm2-tss installation process by introducing a version input for the GitHub Action and replacing a fake version tag with a specific commit SHA (4.1.3) in the documentation. It also simplifies the build command in the README and adds instructions for package manager installation. Feedback suggests optimizing git clone operations in both the CI action and the documentation to avoid full repository clones, recommending blobless clones for CI and shallow clones for manual installation.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CI and documentation to install tpm2-tss from an official, pinned release (v4.1.3) instead of building from a nightly snapshot with a fake version tag, improving reproducibility and reducing versioning risks.
Changes:
- Add a
versioninput to the composite action that builds/installstpm2-tssfrom source and default it to4.1.3. - Update CI workflows to use the composite action with a pinned
tpm2-tsscommit and drop the static-linking env vars. - Refresh README dependency/install instructions to match the new
tpm2-tssinstall approach.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates dependency/install docs to use pinned tpm2-tss v4.1.3 and removes static-linking instructions. |
| .github/workflows/test.yml | Pins tpm2-tss install via the composite action and simplifies test step env. |
| .github/workflows/lint.yml | Pins tpm2-tss install via the composite action for clippy. |
| .github/workflows/build.yml | Pins tpm2-tss install via the composite action and simplifies build step env. |
| .github/actions/install-tpm2-tss/action.yml | Adds a version input and checks out that ref during build/install. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
fb69fe7 to
31ec9ba
Compare
Changes
mainand injecting a fake version tag (4.1.999) with checking out the official v4.1.3 release (commit30e6057)versioninput, making it easy to pin or update the tpm2-tss version across all CI workflowsTSS2_*_STATIC=1) that are no longer neededREADME.mdto reflect the new safe installation method and remove the warning about fake version conflicts