Skip to content

build(deps): use tpm2-tss version 4.1.3 instead of nightly#28

Merged
hyperfinitism merged 1 commit intomainfrom
chore/tpm2-tss-4.1.3
Apr 8, 2026
Merged

build(deps): use tpm2-tss version 4.1.3 instead of nightly#28
hyperfinitism merged 1 commit intomainfrom
chore/tpm2-tss-4.1.3

Conversation

@hyperfinitism
Copy link
Copy Markdown
Owner

Changes

  • Replace the unsafe approach of cloning tpm2-tss nightly main and injecting a fake version tag (4.1.999) with checking out the official v4.1.3 release (commit 30e6057)
  • The composite action now accepts a version input, making it easy to pin or update the tpm2-tss version across all CI workflows
  • Remove the static linking env vars (TSS2_*_STATIC=1) that are no longer needed
  • Update README.md to reflect the new safe installation method and remove the warning about fake version conflicts

@hyperfinitism hyperfinitism requested a review from Copilot April 8, 2026 20:28
@hyperfinitism hyperfinitism self-assigned this Apr 8, 2026
@hyperfinitism hyperfinitism added ci/cd CI/CD related items dependencies Dependency-related items labels Apr 8, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tpm2-tss installation process by introducing a version input for the GitHub Action and replacing a fake version tag with a specific commit SHA (4.1.3) in the documentation. It also simplifies the build command in the README and adds instructions for package manager installation. Feedback suggests optimizing git clone operations in both the CI action and the documentation to avoid full repository clones, recommending blobless clones for CI and shallow clones for manual installation.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s CI and documentation to install tpm2-tss from an official, pinned release (v4.1.3) instead of building from a nightly snapshot with a fake version tag, improving reproducibility and reducing versioning risks.

Changes:

  • Add a version input to the composite action that builds/installs tpm2-tss from source and default it to 4.1.3.
  • Update CI workflows to use the composite action with a pinned tpm2-tss commit and drop the static-linking env vars.
  • Refresh README dependency/install instructions to match the new tpm2-tss install approach.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Updates dependency/install docs to use pinned tpm2-tss v4.1.3 and removes static-linking instructions.
.github/workflows/test.yml Pins tpm2-tss install via the composite action and simplifies test step env.
.github/workflows/lint.yml Pins tpm2-tss install via the composite action for clippy.
.github/workflows/build.yml Pins tpm2-tss install via the composite action and simplifies build step env.
.github/actions/install-tpm2-tss/action.yml Adds a version input and checks out that ref during build/install.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
@hyperfinitism hyperfinitism force-pushed the chore/tpm2-tss-4.1.3 branch from fb69fe7 to 31ec9ba Compare April 8, 2026 20:35
@hyperfinitism hyperfinitism merged commit a1057e1 into main Apr 8, 2026
23 checks passed
@hyperfinitism hyperfinitism deleted the chore/tpm2-tss-4.1.3 branch April 8, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd CI/CD related items dependencies Dependency-related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants