Reset more vcpu state on snapshot::restore #1120
Open
+1,745
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
added
the
kind/enhancement
ludfjig
force-pushed
the
reset_vcpu
branch
3 times, most recently
from
9cfcc9c to
8507c7a
Compare
jsturtevant
reviewed
Dec 16, 2025
jsturtevant
reviewed
Dec 16, 2025
ludfjig
force-pushed
the
reset_vcpu
branch
11 times, most recently
from
d09b1fc to
18d4ff9
Compare
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
jsturtevant
reviewed
Dec 18, 2025
ludfjig
force-pushed
the
reset_vcpu
branch
7 times, most recently
from
1e8d95a to
71d6a38
Compare
jsturtevant
reviewed
Jan 23, 2026
ludfjig
force-pushed
the
reset_vcpu
branch
3 times, most recently
from
2091ef4 to
5ebe998
Compare
dblnz
reviewed
Jan 27, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Good work! I left some comments below.
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
jsturtevant
reviewed
Jan 27, 2026
Contributor
jsturtevant
left a comment
jsturtevant
left a comment
There was a problem hiding this comment.
looking good. A few comments to address otherwise I like it!
dblnz
previously approved these changes
Feb 2, 2026
ludfjig
force-pushed
the
reset_vcpu
branch
2 times, most recently
from
a5d8efa to
54bc12a
Compare
jsturtevant
previously approved these changes
Feb 2, 2026
ludfjig
force-pushed
the
reset_vcpu
branch
2 times, most recently
from
860e82a to
103abe7
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSRs will be added in another PR.
into()implementation for kvm/mshv due to single memcyp, but that seems like premature optimization to meAddresses #791 partially