Consolidate duplicate HypervisorType enum #1203
Open
+1
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jgprog117
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
Removed duplicate HypervisorType enum definition from sandbox/hypervisor.rs and added import to use the existing definition from virtual_machine module. Both enums were identical, so consolidating reduces code duplication and ensures a single source of truth for the hypervisor type enumeration. Fixes hyperlight-dev#1202 Signed-off-by: Jgprog117 <gustafsonjosef@gmail.com>
Jgprog117
force-pushed
the
fix/consolidate-hypervisor-type-enum
branch
from
e4e3563 to
17cd14d
Compare
dblnz
added
the
kind/refactor
dblnz
requested changes
Feb 2, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I left some comments.
Contributor
There was a problem hiding this comment.
It looks like there are also a couple other things that are defined in both files.
I've had a look, and it looks like this file is not used at all, it may be an artifact of some conflict.
Can you remove it please?
If it turns out to not be used at all, could you modify the PR title and/or commit message to reflect that?
Contributor
There was a problem hiding this comment.
agree with this! Thanks a lot for you contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1202 by consolidating duplicate enum definitions.
Changes
Impact
This eliminates code duplication and establishes a single source of truth for the enumeration, improving maintainability.
Fixes #1202