fix: add wasmtime flags! macro support for WIT flags types#1327
Draft
jsturtevant wants to merge 1 commit intomainfrom
Draft
fix: add wasmtime flags! macro support for WIT flags types#1327jsturtevant wants to merge 1 commit intomainfrom
jsturtevant wants to merge 1 commit intomainfrom
Conversation
When is_wasmtime_guest is true, emit wasmtime::component::flags! macro invocations instead of plain structs with bool fields. This enables WIT flags types (e.g. from wasi:filesystem) to satisfy the wasmtime::component::Lift and wasmtime::component::Lower trait bounds. The non-wasmtime code path (used by guest_bindgen and host_bindgen in this repo) is unchanged. The wasmtime path is used by the external hyperlight-wasm crate. Closes #1318 Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
Contributor
Author
|
moved this to draft, I was integrating into hyperlight-wasm and found the usage of flags needs to be slightly different. than this. will push an update shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
is_wasmtime_guestis true, emitwasmtime::component::flags!macro invocations instead of plain structs with bool fields. This enables WIT flags types (e.g. fromwasi:filesystem) to satisfy thewasmtime::component::Liftandwasmtime::component::Lowertrait bounds.The non-wasmtime code path (used by guest_bindgen and host_bindgen in this repo) is unchanged. The wasmtime path is used by the external hyperlight-wasm crate.
Closes #1318
Signed-off-by: James Sturtevant jsturtevant@gmail.com