Skip to content

Defer clearing tlb flush flag #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludfjig wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Defer clearing tlb flush flag #1333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/hyperlight_host/src/hypervisor/hyperlight_vm/x86_64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ impl HyperlightVm {
let mut rflags = 1 << 1; // RFLAGS.1 is RES1
if self.pending_tlb_flush {
rflags |= 1 << 6; // set ZF if we need a tlb flush done before anything else executes
self.pending_tlb_flush = false;
}
// set RIP and RSP, reset others
let regs = CommonRegisters {
Expand All @@ -319,13 +318,20 @@ impl HyperlightVm {
.set_fpu(&CommonFpu::default())
.map_err(DispatchGuestCallError::SetupRegs)?;

self.run(
mem_mgr,
host_funcs,
#[cfg(gdb)]
dbg_mem_access_fn,
)
.map_err(DispatchGuestCallError::Run)
let result = self
.run(
mem_mgr,
host_funcs,
#[cfg(gdb)]
dbg_mem_access_fn,
)
.map_err(DispatchGuestCallError::Run);

// Clear the TLB flush flag only after run() returns. The guest
// may have been cancelled before it executed the flush.
self.pending_tlb_flush = false;

result
}

/// Resets the following vCPU state:
Expand Down
Loading