Add rate limiting, retry logic, and error handling infrastructure#6
Merged
hyperpolymath merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
…etry, BGP/RPKI, tests, CI - Complete NetworkVerifier BGP/RPKI checks via Team Cymru DNS and Cloudflare RPKI API - Implement Certificate Transparency lookup via crt.sh - Complete Zig FFI bridge: replace template placeholders, add feedback-specific ops (compute_hash, generate_id, validate_https), update version to 1.0.0 - Add structured error types (AuthenticationError, RateLimitError, NetworkError, ValidationError, PlatformError, DuplicateError) replacing generic error tuples - Add per-platform RateLimiter with token bucket algorithm and configurable limits - Add Retry module with exponential backoff, jitter, and retryable error classification - Integrate RateLimiter and Retry into Submitter - Update all channel adapters (GitHub, GitLab, Bitbucket, Codeberg, Bugzilla) to return structured errors - Add comprehensive test suite: credentials, audit_log, rate_limiter, retry, channel registry, integration tests for all channel adapters - Add Elixir CI pipeline: multi-version matrix, format check, dialyzer - Synchronize STATE.a2ml to v1.0.0 production status - Add CONTRIBUTING.adoc with language policy, dev guidelines, architecture overview https://claude.ai/code/session_01CdyQBqSt5j3WRoveJWKyip
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces critical infrastructure for production-ready feedback submission: per-platform rate limiting with token bucket algorithm, exponential backoff retry logic with jitter, structured error types, and comprehensive audit logging. Also includes network verification improvements and test coverage for new modules.
Key Changes
Core Infrastructure
rate_limiter.ex): GenServer-backed token bucket rate limiting per platform using ETS for concurrent access. Configurable max requests, time windows, and cooldowns. Prevents AI agents from accidentally spamming platforms.retry.ex): Exponential backoff with jitter for transient failures. Distinguishes retryable errors (network, 5xx) from non-retryable ones (auth, validation, 4xx).error.ex): Replaces generic error tuples with specific exception types:AuthenticationError,RateLimitError,NetworkError,ValidationError,PlatformError,DuplicateError. Provides actionable error information for AI agents.audit_log.ex): JSON-lines audit trail with session tracking, event classification, and sensitive field sanitization. Logs submissions, network checks, deduplication, and credential rotation.Network Verification Enhancements
Channel Improvements
Testing & CI
Documentation & Project Updates
CONTRIBUTING.adocwith language policy, setup instructions, and development guidelinesfeedback_o_tron_*function names instead of templatesIntegration
RateLimiterandRetryintoSubmitterfor production-ready submission flowRateLimiterto application supervision treeNotable Implementation Details
https://claude.ai/code/session_01CdyQBqSt5j3WRoveJWKyip