Skip to content

Fix typos in adding-new-wallets.mdx documentation #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zent7x wants to merge 1 commit into from
Closed

Fix typos in adding-new-wallets.mdx documentation #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/integrating-wallets/adding-new-wallets.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

- [Keplr Extension - Wallet Info](https://github.com/hyperweb-io/cosmos-kit/tree/main/wallets/keplr-extension/src/extension/registry.ts)

- [Keplr Mobile - Wallet Info](https://github.com/hyperweb-io/cosmos-kit/tree/main/wallets/keplr-mobile/src/wallet-connect/registry.ts)jk
- [Keplr Mobile - Wallet Info](https://github.com/hyperweb-io/cosmos-kit/tree/main/wallets/keplr-mobile/src/wallet-connect/registry.ts)

### 2️⃣ Implement `WalletClient` <span id="2-implement-walletclient"></span>

Expand All @@ -74,7 +74,7 @@
| Key | Type | Description |
| -------------------- | --------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------- |
| **getAccount** | `(chainId: string) => Promise<WalletAccount>`<sup>\*</sup> | return account with address, pubkey and algo |
| **getOfflineSigner** | `(chainId: string, preferredSignType?: SignType) => Promise<OfflineSigner>` | prioritize returning `preferredSignType` (by default `amino`) corresponding signer if it is available, otherwise return siger that is provided. |
| **getOfflineSigner** | `(chainId: string, preferredSignType?: SignType) => Promise<OfflineSigner>` | prioritize returning `preferredSignType` (by default `amino`) corresponding signer if it is available, otherwise return signer that is provided. |
| **enable** | `(chainIds: string \| string[]) => Promise<void>` | give permission for the webpage to access wallet |
| **addChain** | `(chainInfo: ChainRecord) => Promise<void>` | add new Cosmos-SDK based blockchains that isn't natively integrated to wallet app/extension |
| **on** | `(type: string, listener: EventListenerOrEventListenerObject) => void` | add event listener |
Expand Down Expand Up @@ -130,4 +130,4 @@ Last but not least, append this instance to the `wallets` property of [ChainProv

## 6️⃣ Don't Forget To Update Docs

Add `Mardown File` just like other wallets [here](https://github.com/hyperweb-io/cosmos-kit/tree/main/packages/docs/pages/integrating-wallets).
Add `Markdown File` just like other wallets [here](https://github.com/hyperweb-io/cosmos-kit/tree/main/packages/docs/pages/integrating-wallets).