Skip to content

Show a timeout for in flight rearming#9769

Merged
DzikuVx merged 2 commits intorelease_7.1.0from
MrD_Show-OSD-message-for-inflight-rearm-possible
Mar 9, 2024
Merged

Show a timeout for in flight rearming#9769
DzikuVx merged 2 commits intorelease_7.1.0from
MrD_Show-OSD-message-for-inflight-rearm-possible

Conversation

@MrD-RC
Copy link
Copy Markdown
Member

@MrD-RC MrD-RC commented Mar 5, 2024

If possible, this will show a countdown time for how long the pilot has to rearm in flight. This was a part of #9688, which wasn't working as expected. This part should work, and give the pilots useful information.

Tested in HITL. Will test in flight asap.

If possible, this will show a countdown time for how long the pilot has to rearm in flight. This was a part of #9688, which wasn't working as expected. This part should work, and give the pilots useful information.

Currently not tested. Will test in HITL, then in flight asap.
@MrD-RC MrD-RC added this to the 7.1 milestone Mar 5, 2024
@MrD-RC MrD-RC marked this pull request as ready for review March 5, 2024 22:14
If the save is happening, writing to EEPROM locks up the FC. This change will only show the rearm message if the FC is not currently saving.

If rearm is available, the `** SETTINGS SAVED**` message will not appear, to maximise time for rearm.

If rearm is not available. The save messages display as normal.
@rmaia3d
Copy link
Copy Markdown
Contributor

rmaia3d commented Mar 6, 2024

By this last commit 7929838, so if re-arm is possible, the settings save will also be delayed by the same time window where emergency-rearm is available?

If so, this could help with the ESC resetting that originated the efforts in #9688.

@MrD-RC
Copy link
Copy Markdown
Member Author

MrD-RC commented Mar 6, 2024

By this last commit 7929838, so if re-arm is possible, the settings save will also be delayed by the same time window where emergency-rearm is available?

If so, this could help with the ESC resetting that originated the efforts in #9688.

No, this is just to show the timer. I have another branch I’m working on that aims to not save in flight. But there are issues that need more time given to them to solve. #9688

@rmaia3d
Copy link
Copy Markdown
Contributor

rmaia3d commented Mar 7, 2024

No, this is just to show the timer. I have another branch I’m working on that aims to not save in flight. But there are issues that need more time given to them to solve. #9688

Ah, ok! Just the timer will be a nice thing already. :)

@DzikuVx DzikuVx merged commit f025ee5 into release_7.1.0 Mar 9, 2024
@MrD-RC
Copy link
Copy Markdown
Member Author

MrD-RC commented Mar 9, 2024

@DzikuVx did you get a chance to test this in flight? I still needed to get that done, especially with MSP DisplayPort.

This may have been merged prematurely.

@Jetrell
Copy link
Copy Markdown

Jetrell commented Mar 24, 2024

I tested again just to be sure. And it prevents inflight rearming from working with quads that are using MSP displayport (Avatar anyway). Very strange behavior.

@MrD-RC MrD-RC deleted the MrD_Show-OSD-message-for-inflight-rearm-possible branch October 27, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants