Skip to content

Fix testing issue#20

Open
DDibyajyot wants to merge 7 commits intoiamDyeus:mainfrom
DDibyajyot:fix-testing-issue
Open

Fix testing issue#20
DDibyajyot wants to merge 7 commits intoiamDyeus:mainfrom
DDibyajyot:fix-testing-issue

Conversation

@DDibyajyot
Copy link
Copy Markdown

Closes issue #16

The changes address recent test failures and other areas for improvement identified in the CI pipeline logs (CI pipeline run).

Added testing guidelines and documentation in CONTRIBUTING.md for future testing purposes.

This PR aims to maintain a clean and reliable test suite that thoroughly validates core functionality and supports further development with confidence.

@DDibyajyot
Copy link
Copy Markdown
Author

@iamDyeus Hey, have a look and let me know if it looks good. I have added testing guidelines in contributing.md and made it so pytest actually works.

@iamDyeus
Copy link
Copy Markdown
Owner

iamDyeus commented Nov 1, 2024

@DDibyajyot Everything looks great! However, I think we’ll also need to update .github/workflows/ci.yml since the current command and the one in your commit have recently changed the implementation. Please ping me once this is fixed.

@iamDyeus iamDyeus mentioned this pull request Nov 1, 2024
@iamDyeus iamDyeus added hacktoberfest24 Indicates the repository is participating in Hacktoberfest. hacktoberfest-accepted Marks individual PRs as Hacktoberfest-eligible. labels Nov 1, 2024
@DDibyajyot
Copy link
Copy Markdown
Author

@iamDyeus I have updated it, thank you for pointing it out to me! It should work with the new implementation now.

@DDibyajyot
Copy link
Copy Markdown
Author

Interesting, I see the checks are failing, let me fix that

@iamDyeus
Copy link
Copy Markdown
Owner

iamDyeus commented Nov 1, 2024

Interesting, I see the checks are failing, let me fix that

Yeah, you'll probably need to update upload-artifact to v3, checkout to v3, and setup-python to v4 as earlier versions are likely deprecated in ci.yml.

@DDibyajyot
Copy link
Copy Markdown
Author

Hopefully everything should be fine, I followed your advise and updated all 3 to newer versions

add PYTHONPATH, bumped python version to 3.12
@DDibyajyot
Copy link
Copy Markdown
Author

The checks are confusing, I agree with the command for debug, but why has the dependency error come up when it has been there since the beginning?

@iamDyeus
Copy link
Copy Markdown
Owner

iamDyeus commented Nov 3, 2024

The checks are confusing, I agree with the command for debug, but why has the dependency error come up when it has been there since the beginning?

The dependency error arised because I bumped the Python version from 3.8 to 3.12 in ci.yml. I think the main issue is how the workflow is trying to locate the src path. I'll take a look when I have a bit more time, but if you could try to debug and fix it in the meantime, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest24 Indicates the repository is participating in Hacktoberfest. hacktoberfest-accepted Marks individual PRs as Hacktoberfest-eligible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants