Open
Conversation
Preview of modified filesPreview of modified Markdown: |
mnocon
commented
Feb 13, 2026
| if (req.restarts == 0 | ||
| && (req.http.accept ~ "application/vnd.fos.user-context-hash" | ||
| || req.http.X-Context-User-Hash | ||
| || req.http.x-user-context-hash |
Contributor
Author
There was a problem hiding this comment.
Note: I've adjusted it to be in line with https://github.com/ibexa/http-cache/blob/4.6/docs/varnish/vcl/varnish7.vcl (which uses lowercase here)
|
vidarl
approved these changes
Feb 26, 2026
ibexa-workflow-automation-1
bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
dabrt
approved these changes
Feb 26, 2026
|
|
||
| As explained in [User Context Hash caching](context_aware_cache.md#user-context-hash-caching), the HTTP cache indexes the cache based on the user-context-hash. | ||
| Users with the same user-context-hash here the same cache (as long as [[= product_name =]] responds with `Vary: X-Context-User-Hash`). | ||
| Users with the same user-context-hash here the same cache (as long as [[= product_name =]] responds with `Vary: X-User-Context-Hash`). |
Contributor
There was a problem hiding this comment.
@vidarl Please help me understand the sentence - it seems off, like the verb is missing. Is it... "users... here USE the same cache"?
mnocon
commented
Feb 26, 2026
|
|
||
| As explained in [User Context Hash caching](context_aware_cache.md#user-context-hash-caching), the HTTP cache indexes the cache based on the user-context-hash. | ||
| Users with the same user-context-hash here the same cache (as long as [[= product_name =]] responds with `Vary: X-Context-User-Hash`). | ||
| Users with the same user-context-hash here the same cache (as long as [[= product_name =]] responds with `Vary: X-User-Context-Hash`). |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| Users with the same user-context-hash here the same cache (as long as [[= product_name =]] responds with `Vary: X-User-Context-Hash`). | |
| Users with the same user-context-hash share the same cache (as long as [[= product_name =]] responds with `Vary: X-User-Context-Hash`). |
That's how I'd write it based on my knowledge, @vidarl please confirm 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IBX-11331
Target: 4.6, 5.0, 3.3
Note: I've adjusted the casing in some lines (see comments) to make it match our VCLs.