Demonstrate next_occurrences bug.#524
Open
flivni wants to merge 2 commits intoice-cube-ruby:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like there is a bug where if you pass a
fromtime toschedule.next_occurrencesthat is close to the DST boundary, you can get future occurrences that occur on the wrong time.E.g. A recurring appointment that occurs every Sunday at 01:15 am London time. If you call
schedule.next_occurrences(from_time)where from_time is just prior to March 27, 2022 01:00 am, all occurrences shift an hour forward to 2:15 am local time.