Add Implicit Connection with Secure Data#5
Open
simy307 wants to merge 2 commits intoicetee:masterfrom
Open
Conversation
icetee
requested changes
May 23, 2018
Owner
icetee
left a comment
There was a problem hiding this comment.
Hi, thank you for the PR! I try to test it soon.
package.json
Outdated
| { | ||
| "name": "@icetee/ftp", | ||
| "version": "1.0.2", | ||
| "version": "1.0.3", |
Owner
|
I watched your code, but is the same as if I set Otherwise, I get an error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a connection can be made with the "Implicit" option. However the data being transferred is not encrypted and an error would be passed down from the server
This change would allow a connection with both an "Implicit" connection type and "Secure" data.