Fix conversion of backing fields of overridable properties#1237
Fix conversion of backing fields of overridable properties#1237GrahamTheCoder wants to merge 1 commit intomasterfrom
Conversation
This commit fixes issue #827 where accessing the auto-generated backing field (e.g. `_Prop`) of an overridable (virtual) property in VB.NET was incorrectly converted to the virtual property access (`Prop`) in C#. It now correctly maps these accesses to the explicitly generated non-virtual backing property `MyClassProp` and ensures that the MyClassProp property is correctly generated when such an access occurs. A test case has been added to MemberTests.cs to verify the correct translation of such field access. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses issue #827, ensuring that accessing the backing field of an overridable property is correctly translated to accessing
MyClass[PropertyName]. It also properly identifies these accesses using semantic analysis to trigger the generation of theMyClass[PropertyName]delegating auto-property. Added corresponding unit tests inMemberTests.csto guarantee behavior.PR created automatically by Jules for task 2635451807914525187 started by @GrahamTheCoder