Fix Issue #803: Use relational patterns in switch statements#1239
Fix Issue #803: Use relational patterns in switch statements#1239GrahamTheCoder wants to merge 1 commit intomasterfrom
Conversation
- Modifies `MethodBodyExecutableStatementVisitor` to generate `RelationalPatternSyntax` instead of `VarPattern` with a `when` clause for VB `RelationalCaseClauseSyntax`. - Adds helper `GetRelationalTokenKind` to map VB syntax kinds to the appropriate C# relational operators. - Added corresponding unit test demonstrating the new output. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes #803 by generating native C# 9 relational patterns for switch cases (e.g.
case < 1000:instead ofcase var @case when @case < 1000:). This simplifies the generated code and matches modern C# conventions.PR created automatically by Jules for task 13318111578509939019 started by @GrahamTheCoder