Skip to content

Fix VB -> C# char comparison with empty string#1240

Draft
GrahamTheCoder wants to merge 1 commit intomasterfrom
fix-char-empty-string-equality-2639555887942549494
Draft

Fix VB -> C# char comparison with empty string#1240
GrahamTheCoder wants to merge 1 commit intomasterfrom
fix-char-empty-string-equality-2639555887942549494

Conversation

@GrahamTheCoder
Copy link
Member

Fixes #892 by handling the equality comparison of a Char type and an empty string literal "".

In VB.NET, testChar = "" evaluates to True if testChar is char.MinValue. Before this change, the code converter converted this condition into Conversions.ToString(testChar) == "", which evaluates differently.
This patch maps such comparisons to testChar == char.MinValue or char.MinValue == testChar by ensuring that "" translates to char.MinValue when the other argument is of type System_Char.


PR created automatically by Jules for task 2639555887942549494 started by @GrahamTheCoder

Map VB.NET char comparison with an empty string to char.MinValue to match runtime behavior and prevent logic errors during compilation. Added a unit test.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VB -> C#: wrong result for empty char comparisation

1 participant