Skip to content

handle graceful shutdown of consumers#137

Merged
kristinmerbach merged 14 commits intotrunkfrom
graceful_shutdown_of_consumers_v2
Feb 25, 2026
Merged

handle graceful shutdown of consumers#137
kristinmerbach merged 14 commits intotrunkfrom
graceful_shutdown_of_consumers_v2

Conversation

@vkghub
Copy link
Contributor

@vkghub vkghub commented Feb 3, 2026

@vkghub vkghub added the enhancement New feature or request label Feb 3, 2026
@vkghub vkghub self-assigned this Feb 3, 2026
@vkghub vkghub requested a review from raghuramg February 4, 2026 03:50
@vkghub vkghub marked this pull request as ready for review February 4, 2026 13:01
Copy link
Contributor

@saipraveen18 saipraveen18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@raghuramg raghuramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented logic to add wait for message to drain before shutting down.

code changes looks good to me

@kristinmerbach kristinmerbach merged commit d108374 into trunk Feb 25, 2026
14 checks passed
vkghub added a commit to dchbx/event_source that referenced this pull request Feb 27, 2026
* handle graceful shutdown of Bunny (AMQP client)

* rearrange methods

* add more changes and specs

* remove unused

* add more specs

* add railtie spec

* fix typo

* spec fix

* fix path

* revert spec config

* revert spec

* test spec

* test one more change

* remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants