This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Refactor Pipeline to Vec<Command> with .effect() and .rotate_angle()#4
Open
Refactor Pipeline to Vec<Command> with .effect() and .rotate_angle()#4
Conversation
Pipeline now builds a Vec<Command> internally instead of using fixed fields. plan() delegates to compute_layout_sequential(), which means the order of builder calls determines command evaluation order. New builder methods: - .effect(impl DimensionEffect) — insert any dimension effect - .rotate_angle(degrees, mode) — cardinal angles map to Command::Rotate (free, D4 composable), non-cardinal to Command::Effect(RotateEffect) Existing API is fully backward compatible: .auto_orient().crop().within() .pad() produces the same command sequence as the old fixed pipeline. Removes dead SourceRegion enum (Pipeline no longer needs it).
lilith
added a commit
to imazen/zenpipe
that referenced
this pull request
Apr 13, 2026
Adds support for arbitrary-angle rotation in the geometry bridge. The new `zenlayout.rotate_angle` schema ID accepts `degrees` (f32) and `mode` (crop/expand/original) parameters. Pipeline.rotate_angle() handles dispatch: cardinal angles (0/90/180/270) compose into the D4 orientation group (free), non-cardinal angles produce a RotateEffect that the planner tracks as a dimension-changing effect. Depends on zenlayout Pipeline refactor (imazen/zenlayout#4) and zenresize re-exports (imazen/zenresize#4).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fully backward compatible: existing `.auto_orient().crop().within().pad()` chains produce the same results.
Test plan