chore: regression tests for fixed issue #916#1215
Open
oriondean wants to merge 1 commit intoimmerjs:mainfrom
Open
chore: regression tests for fixed issue #916#1215oriondean wants to merge 1 commit intoimmerjs:mainfrom
oriondean wants to merge 1 commit intoimmerjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first time contributor here! I've been a long term user (directly and indirectly) of immer so I'm really happy to contribute back.
I'm starting off with a relatively simple addition of regression tests verifying that issue #916 has been addressed.
This issue was originally fixed in PR 917, landing in
v9.0.19of immer. You should find that bumping the version of immer to that version in the issue's referenced codesandbox will demonstrate it is no longer an issue.