CROSSLINK-252 Add option to broadcast all event states#522
Open
JanisSaldabols wants to merge 1 commit intomainfrom
Open
CROSSLINK-252 Add option to broadcast all event states#522JanisSaldabols wants to merge 1 commit intomainfrom
JanisSaldabols wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an option to broadcast task state transitions (begin/complete) across all EventBus instances by persisting the event.broadcast flag during status transitions, and wiring new “broadcast” variants into task processing.
Changes:
- Extend
UpdateEventStatusSQL to also update thebroadcastcolumn. - Add
BeginTaskBroadcast/CompleteTaskBroadcast/ProcessTaskBroadcastto theEventBusAPI and implement them inPostgresEventBus. - Switch ISO18626 client task processing for message tasks to use
ProcessTaskBroadcast.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| broker/sqlc/event_query.sql | Updates UpdateEventStatus to persist broadcast during status changes. |
| broker/events/eventbus.go | Adds broadcast variants for begin/complete/process task flows and refactors shared logic. |
| broker/client/client.go | Uses broadcast task processing for message-requester and message-supplier tasks. |
| func (c *Iso18626Client) MessageSupplier(ctx common.ExtendedContext, event events.Event) { | ||
| ctx = ctx.WithArgs(ctx.LoggerArgs().WithComponent(CLIENT_COMP)) | ||
| _, _ = c.eventBus.ProcessTask(ctx, event, c.createAndSendRequestOrRequestingAgencyMessage) | ||
| _, _ = c.eventBus.ProcessTaskBroadcast(ctx, event, c.createAndSendRequestOrRequestingAgencyMessage) |
| } | ||
|
|
||
| func (p *PostgresEventBus) ProcessTaskBroadcast(ctx common.ExtendedContext, event Event, h func(common.ExtendedContext, Event) (EventStatus, *EventResult)) (Event, error) { | ||
| return p.processTask(ctx, event, h, p.BeginTaskBroadcast, p.CompleteTaskBroadcast) |
Comment on lines
+390
to
+392
| func (p *PostgresEventBus) ProcessTaskBroadcast(ctx common.ExtendedContext, event Event, h func(common.ExtendedContext, Event) (EventStatus, *EventResult)) (Event, error) { | ||
| return p.processTask(ctx, event, h, p.BeginTaskBroadcast, p.CompleteTaskBroadcast) | ||
| } |
| func (c *Iso18626Client) MessageRequester(ctx common.ExtendedContext, event events.Event) { | ||
| ctx = ctx.WithArgs(ctx.LoggerArgs().WithComponent(CLIENT_COMP)) | ||
| _, _ = c.eventBus.ProcessTask(ctx, event, c.createAndSendSupplyingAgencyMessage) | ||
| _, _ = c.eventBus.ProcessTaskBroadcast(ctx, event, c.createAndSendSupplyingAgencyMessage) |
jakub-id
reviewed
Apr 15, 2026
| @@ -75,7 +75,7 @@ DELETE FROM event | |||
| WHERE ill_transaction_id = $1; | |||
|
|
|||
| -- name: UpdateEventStatus :one | |||
Contributor
There was a problem hiding this comment.
Maybe rename this to something like UpdateEventLifecycle
| func (p *PostgresEventBus) processTask(ctx common.ExtendedContext, event Event, h func(common.ExtendedContext, Event) (EventStatus, *EventResult), b func(eventId string) (Event, error), c func(eventId string, result *EventResult, status EventStatus) (Event, error)) (Event, error) { | ||
| inEvent := &event | ||
| event, err := p.BeginTask(event.ID) | ||
| event, err := b(event.ID) |
Contributor
There was a problem hiding this comment.
Could we call these handlers something more readable like begin and complete?
Contributor
|
@JanisSaldabols I am not sure this is gonna work as-is. Workflow OnRequester/SupplierMessage handler already broadcast the confirmation task so we will have a double broadcast. If we wanna do it this way we would need to get rid of the confirmation task and confirm directly in these handlers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.