Skip to content

Add add-condition action to CONDITION_PENDING#523

Merged
jakub-id merged 1 commit intomainfrom
add-condition-while-pending
Apr 15, 2026
Merged

Add add-condition action to CONDITION_PENDING#523
jakub-id merged 1 commit intomainfrom
add-condition-while-pending

Conversation

@jakub-id
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 15, 2026 10:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for invoking the supplier-side add-condition action while a returnable Patron Request is already in CONDITION_PENDING, enabling suppliers to send additional conditions without leaving the state.

Changes:

  • Added add-condition as an allowed action in the CONDITION_PENDING supplier state (self-transition on success).
  • Updated the embedded returnables.json state model to match the YAML spec change.
  • Extended ActionMapping tests to assert availability, listing, and transition behavior for add-condition in CONDITION_PENDING.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
misc/returnables.yaml Adds add-condition action to supplier CONDITION_PENDING state with a self-transition.
broker/patron_request/service/statemodels/returnables.json Mirrors the state model change in the embedded JSON used at runtime.
broker/patron_request/service/action_mapping_test.go Updates/extends tests to cover the new action availability and transition in CONDITION_PENDING.

@jakub-id jakub-id merged commit 1219eab into main Apr 15, 2026
8 checks passed
@jakub-id jakub-id deleted the add-condition-while-pending branch April 15, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants