Skip to content

Replace pkg_resources with importlib.resources #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Feb 15, 2026
Merged

Replace pkg_resources with importlib.resources #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03c091b
Initial plan
Copilot Feb 15, 2026
3c2a839
Replace pkg_resources with importlib.resources
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codepy/libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ def get_numpy_incpath() -> str:

def add_py_module(toolchain: Toolchain, name: str) -> None:
def get_module_include_path(name: str) -> str:
from pkg_resources import Requirement, resource_filename
return resource_filename(Requirement.parse(name), f"{name}/include")
from importlib.resources import files
return str(files(name) / "include")

Comment on lines +188 to 190
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importlib.resources.files() returns a Traversable that is not guaranteed to be a real filesystem path (e.g., zip/egg installs). Converting it to str and passing it as a compiler -I include dir can yield a non-existent path and break compilation, whereas pkg_resources.resource_filename() previously extracted resources to a real path. Consider resolving the package location via importlib.util.find_spec(...).submodule_search_locations (filesystem-only, like add_numpy) or materializing the directory with importlib.resources.as_file() and ensuring the extracted path remains valid for the entire build.

Suggested change
from importlib.resources import files
return str(files(name) / "include")
from importlib.util import find_spec
spec = find_spec(name)
if spec is None:
raise RuntimeError(f"Could not find module '{name}'")
libdir = spec.submodule_search_locations
assert libdir is not None
from os.path import join
return join(libdir[0], "include")

Copilot uses AI. Check for mistakes.
toolchain.add_library(name, [get_module_include_path(name)], [], [])

Expand Down
Loading