Skip to content

Order vector tp#165

Merged
inducer merged 3 commits intomainfrom
order-vector-tp
Mar 19, 2026
Merged

Order vector tp#165
inducer merged 3 commits intomainfrom
order-vector-tp

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Mar 19, 2026

  • Still waiting on a test, currently being made by Claude (maybe?)

cc @ShawnL00

This makes inducer/meshmode#494 way neater.

@inducer inducer marked this pull request as ready for review March 19, 2026 18:17
@inducer inducer requested review from alexfikl and Copilot March 19, 2026 18:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR generalizes modal-decay utilities to support tensor-product bases by introducing a basis-aware “degree vector” and a new interpolation error coefficient estimator matrix API, along with a new regression test covering simplex and hypercube shapes.

Changes:

  • Add degree_vector() (with simplex/tensor-product implementations) and interp_error_coefficient_estimator_matrix(), and deprecate simplex_interp_error_coefficient_estimator_matrix.
  • Expose a new public SimplexBasis base class (renaming the previous private _SimplexBasis).
  • Add a new test validating that the estimator tracks actual interpolation error across shapes and smoothness classes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

File Description
modepy/test/test_tools.py Adds a new test for interp_error_coefficient_estimator_matrix across simplex/hypercube shapes.
modepy/modes.py Renames _SimplexBasis to public SimplexBasis and updates internal subclasses accordingly; updates docs section.
modepy/modal_decay.py Adds degree_vector singledispatch, adds new estimator-matrix API, and deprecates the simplex-only helper.
modepy/__init__.py Exports SimplexBasis from the top-level package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a little nitpick, otherwise looks good to me!

@inducer inducer merged commit 4f575cf into main Mar 19, 2026
13 checks passed
@inducer inducer deleted the order-vector-tp branch March 19, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants