Merged
Conversation
a89422e to
58adc19
Compare
58adc19 to
ff70cc1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generalizes modal-decay utilities to support tensor-product bases by introducing a basis-aware “degree vector” and a new interpolation error coefficient estimator matrix API, along with a new regression test covering simplex and hypercube shapes.
Changes:
- Add
degree_vector()(with simplex/tensor-product implementations) andinterp_error_coefficient_estimator_matrix(), and deprecatesimplex_interp_error_coefficient_estimator_matrix. - Expose a new public
SimplexBasisbase class (renaming the previous private_SimplexBasis). - Add a new test validating that the estimator tracks actual interpolation error across shapes and smoothness classes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
modepy/test/test_tools.py |
Adds a new test for interp_error_coefficient_estimator_matrix across simplex/hypercube shapes. |
modepy/modes.py |
Renames _SimplexBasis to public SimplexBasis and updates internal subclasses accordingly; updates docs section. |
modepy/modal_decay.py |
Adds degree_vector singledispatch, adds new estimator-matrix API, and deprecates the simplex-only helper. |
modepy/__init__.py |
Exports SimplexBasis from the top-level package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
alexfikl
approved these changes
Mar 19, 2026
Collaborator
alexfikl
left a comment
There was a problem hiding this comment.
Left a little nitpick, otherwise looks good to me!
ff70cc1 to
cbad67f
Compare
cbad67f to
a2a7bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ShawnL00
This makes inducer/meshmode#494 way neater.