Skip to content

Early interp#307

Draft
inducer wants to merge 6 commits intomainfrom
early-interp
Draft

Early interp#307
inducer wants to merge 6 commits intomainfrom
early-interp

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Mar 12, 2026

@alexfikl: @ShawnL00 noticed this. A good place to start is the docstring of the test, to understand the issue being addressed.

Draft because I think EarlyInterpolationAdder may need tweaking to handle all the densities that get thrown at it.

To do:

  • Why are we calling weights_area_elements in the iteration loop?
    • get_flat_strengths_from_densities: better cache waa
  • How does main avoid upsampling quad weights?
    • Possible: it doesn't. It just does so consistently.
  • Add a never-upsample-weights check
  • Longer-term: make interpolation need-driven rather than unconditional

Notes:

  • This breaks the scalar_int_eq tests because the "input side" of the "Bremer" weights gets processed differently from the output side.
  • EarlyInterpolationAdder will happily upsample QWeight, which it very much should not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant