Add QBXRefinementMode enum, deprecate _disable_refinement#310
Draft
Add QBXRefinementMode enum, deprecate _disable_refinement#310
Conversation
Co-authored-by: inducer <352067+inducer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a refinement mode with no refinement and complain option
Add QBXRefinementMode enum, deprecate _disable_refinement
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_disable_refinementwas a blunt boolean with no way to detect when refinement would be needed without actually doing it. Replaces it with a proper enum supporting three modes.New API
Changes
pytential/qbx/refinement.py: AddedQBXRefinementModeenum (REFINE,NO_REFINEMENT,COMPLAIN) andQBXRefinementNeededErrorexception. Updated_refine_qbx_stage1and_refine_qbx_stage2to checkrefinement_mode; theCOMPLAINpath runs all criteria checks and raises with a message identifying the violated criteria if any refinement would be triggered.pytential/qbx/__init__.py: Replaced_disable_refinement: boolattribute withrefinement_mode: QBXRefinementMode. Both__init__andcopy()accept the newrefinement_modeparameter._disable_refinementis retained as a deprecated parameter that maps to the equivalent mode with aDeprecationWarning.QBXRefinementModeandQBXRefinementNeededErrorare exported frompytential.qbx.test/extra_int_eq_data.py: Updated to userefinement_modeinstead of_disable_refinement.Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.