Merged
Conversation
inducer
commented
Mar 18, 2026
There was a problem hiding this comment.
Pull request overview
Adds new coefficient-translation verification tests to the sumpy/test suite, consolidating prior work from #260 and #261 to validate “difference formula” relationships between compressed and full expansion translations.
Changes:
- Add an L2L coefficient-difference verification test across several kernels.
- Add an M2M coefficient-difference verification test across several kernels.
- Introduce shared symbolic-to-numeric helper utilities and update the basedpyright baseline accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
sumpy/test/test_m2m_coeffs.py |
New M2M translation coefficient difference verification test. |
sumpy/test/test_l2l_coeffs.py |
New L2L translation coefficient difference verification test. |
sumpy/test/coeff_test_tools.py |
New shared helpers for symbolic substitution and numeric matvec/matrix building. |
.basedpyright/baseline.json |
Baseline update to account for new files / type-checking findings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
Author
|
Good to go from my end, subject to license approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsumes #260 and #261.