Skip to content

Verify translation difference formulas#272

Merged
inducer merged 2 commits intomainfrom
verify-translation-formulas
Mar 19, 2026
Merged

Verify translation difference formulas#272
inducer merged 2 commits intomainfrom
verify-translation-formulas

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Mar 18, 2026

Subsumes #260 and #261.

Copilot AI review requested due to automatic review settings March 18, 2026 20:26
This was referenced Mar 18, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new coefficient-translation verification tests to the sumpy/test suite, consolidating prior work from #260 and #261 to validate “difference formula” relationships between compressed and full expansion translations.

Changes:

  • Add an L2L coefficient-difference verification test across several kernels.
  • Add an M2M coefficient-difference verification test across several kernels.
  • Introduce shared symbolic-to-numeric helper utilities and update the basedpyright baseline accordingly.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
sumpy/test/test_m2m_coeffs.py New M2M translation coefficient difference verification test.
sumpy/test/test_l2l_coeffs.py New L2L translation coefficient difference verification test.
sumpy/test/coeff_test_tools.py New shared helpers for symbolic substitution and numeric matvec/matrix building.
.basedpyright/baseline.json Baseline update to account for new files / type-checking findings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@inducer
Copy link
Owner Author

inducer commented Mar 18, 2026

Good to go from my end, subject to license approval.

@inducer inducer merged commit 9b0e892 into main Mar 19, 2026
13 checks passed
@inducer inducer deleted the verify-translation-formulas branch March 19, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants