fix: use correct RELEASE_VERSION for config_helper.exs#12
Merged
Conversation
rymcol
requested changes
Mar 11, 2026
| build-args: | | ||
| BLOCKSCOUT_VERSION=${{ github.ref_name }}+commit.${{ steps.version.outputs.short_sha }} | ||
| RELEASE_VERSION=${{ steps.version.outputs.version }} | ||
| RELEASE_VERSION=10.0.0 |
| build-args: | | ||
| BLOCKSCOUT_VERSION=${{ github.ref_name }}+commit.${{ steps.version.outputs.short_sha }} | ||
| RELEASE_VERSION=${{ steps.version.outputs.version }} | ||
| RELEASE_VERSION=10.0.0 |
The Dockerfile copies config_helper.exs to /app/releases/${RELEASE_VERSION}/
This must match the Elixir release version defined in rel/config.exs.
Now extracts the version dynamically with:
grep -oP 'set version: "\K[^"]+' rel/config.exs
This way it stays in sync with upstream without manual updates.
init4samwise
force-pushed
the
fix/release-version-mismatch
branch
from
6d3208f to
c173239
Compare
rymcol
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Dockerfile copies
config_helper.exsto/app/releases/${RELEASE_VERSION}/but we were passing our git tag version (e.g.1.0.1-init4) instead of the actual Elixir release version (10.0.0fromrel/config.exs).This caused
config_helper.exsto be missing from the expected location, breaking runtime config loading.Fix
Hardcode
RELEASE_VERSION=10.0.0to match the Elixir release version defined inrel/config.exs.Note
If blockscout upstream bumps their release version, we'll need to update this value accordingly.