fix: handle pagination when fetching bundles and txs#239
Merged
Conversation
Fraser999
changed the title
dylanlott
approved these changes
Mar 9, 2026
Contributor
dylanlott
left a comment
dylanlott
left a comment
There was a problem hiding this comment.
Approving to promote to test net for full volume testing. Need to follow up with a tagged release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the builder to fetch all transactions and bundles from the tx-pool rather than just the first page's worth.
We'll ticket a follow-up to create a streaming endpoint in the tx-pool for bundles, and to have the builder use that rather than handling pagination itself.
NOTE: This includes a version bump to 1.0.0-rc.6
Related Issue
Closes ENG-1973.
Testing
make fmtpassesmake clippypassesmake testpasses