[hackathon] refactor: make AliasOracle::should_alias async via RPITIT#101
Closed
prestwich wants to merge 2 commits intofeat/host-context-adapterfrom
Closed
[hackathon] refactor: make AliasOracle::should_alias async via RPITIT#101prestwich wants to merge 2 commits intofeat/host-context-adapterfrom
prestwich wants to merge 2 commits intofeat/host-context-adapterfrom
Conversation
prestwich
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
prestwich
force-pushed
the
prestwich/async-alias-oracle-v2
branch
from
c312556 to
6b29571
Compare
Member
Author
|
[Claude Code] Closing — commits cherry-picked into #100 (feat/host-context-adapter). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on #100 (
feat/host-context-adapter).AliasOracle::should_aliasasync using return-positionimpl Traitin traits (RPITIT)HashSet<Address>,RethAliasOracle) pre-compute results and wrap inasync move { result }This prepares the trait for future implementations that need async I/O (e.g., network calls to check alias status).
Test plan
cargo clippypasses forsignet-block-processor,signet-host-reth,signet-node,signet-node-testscargo t -p signet-block-processorpassescargo t -p signet-node-testspasses (42 tests, 0 failures)cargo +nightly fmtclean🤖 Generated with Claude Code