fix: create alias oracle once per block instead of per address#102
Merged
fix: create alias oracle once per block instead of per address#102
Conversation
AliasOracleFactory::create() was called for every address in the transaction loop, causing each check to potentially see different host state. Move the create() call before the loop so all addresses in a block are checked against the same state snapshot. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Explain why Latest is safe (EOAs can't become contracts without a birthday attack), the only risk (computationally infeasible collision), and why over-aliasing is benign compared to under-aliasing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fraser999
approved these changes
Mar 13, 2026
Evalir
approved these changes
Mar 13, 2026
4 tasks
prestwich
added a commit
that referenced
this pull request
Mar 13, 2026
- Remove `should_alias` helper that recreated the oracle per address, restoring the fix from #102 (create oracle once per block) - Revert unrelated rpc/interest changes back to develop Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance fix: creates the alias oracle once per block instead of once per address lookup.
AliasOracleFactory::create()before the address loop so all addresses in a block are checked against the same host state snapshotshould_aliashelper methodRethAliasOracleFactory::create()with a full correctness analysis of whyLatestis safe (EOA→contract transitions require a birthday attack, and even then the failure mode is benign over-aliasing)Previously, each address in a block called
create()→state_by_block_number_or_tag(Latest), opening a new state snapshot per address. Now a single snapshot is shared across the block.Linear: ENG-2037
Test plan
cargo clippy -p signet-block-processor --all-features --all-targetscargo clippy -p signet-node --all-features --all-targetscargo +nightly fmtcargo t -p signet-block-processorcargo t -p signet-nodecargo t -p signet-node-tests🤖 Generated with Claude Code