feat: send ChainEvent::Reorg from node on host revert#95
Merged
Conversation
Wire up reorg notifications in on_host_revert() so the RPC layer receives removed rollup block hashes and logs before storage is unwound. Uses the new drain_above() method from signet-storage which reads headers from hot storage and receipts from cold storage before performing the unwind. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
prestwich
force-pushed
the
prestwich/eng-1968
branch
from
e2d26ba to
88f629e
Compare
Evalir
approved these changes
Mar 9, 2026
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
lgtm, the biggest change is on the actual deps, this looks fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_host_revert()async and usedrain_above()from signet-storage to read rollup block headers and receipts before unwinding storagenotify_reorg()helper that constructs aReorgNotificationwith removed block hashes and logs, and broadcasts it viaChainNotifier::send_reorg()james/eng-1978branch which adds thedrain_abovemethodCloses ENG-1968. Depends on init4tech/storage
james/eng-1978(ENG-1978).Key design decisions
drain_above()before the unwind destroys them.notify_reorgtakesVec<DrainedBlock>by value and movesRpcLog.innerout rather than cloning.Test plan
cargo clippy -p signet-node --all-features --all-targets— cleancargo +nightly fmt— cleancargo t -p signet-node— pass🤖 Generated with Claude Code