fix: flatten SignedOrder serialization to match Rust serde#37
Open
init4samwise wants to merge 1 commit intomainfrom
Open
fix: flatten SignedOrder serialization to match Rust serde#37init4samwise wants to merge 1 commit intomainfrom
init4samwise wants to merge 1 commit intomainfrom
Conversation
…st serde Rust's SignedOrder uses #[serde(flatten)] on the Permit2Batch field, which hoists `owner` and `signature` to be siblings of `permit` in JSON. The TypeScript type and serialization functions were nesting them inside `permit`, causing a shape mismatch with the Rust implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
prestwich
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializedSignedOrdertype to hoistownerandsignatureto the top level, matching Rust's#[serde(flatten)]onPermit2BatchserializeOrder()anddeserializeOrder()to produce/consume the correct flattened shapeCloses ENG-2039
Test plan
pnpm typecheck,pnpm lint,pnpm format:checkall pass🤖 Generated with Claude Code