Conversation
9b8db89 to
8a2fd7b
Compare
| { | ||
| "name": "@elastic/elasticsearch", | ||
| "policy": "45-days", | ||
| "versions": ["7.9.0", "7.17.0", "8.15.0"], |
There was a problem hiding this comment.
"versions": ">= 7"
"versions": ">= 7, 8.15.0"
testUtils.getVersions(versions, nameOfTheLib)
[latest7, latest8, latest9]
What is the currency bot doing?
- Major updates?
- Visibility: we want to know if a minor versions comes out and we are able to check the features
- Visibility: on what is tested
There was a problem hiding this comment.
"versions": ">= 7"
If we use this notation in the currencies.json, we need to initially generate the currencies.json the following:
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.15.0"]
...In the test we use:
CURRENCY.testedVersions.forEach(...)
The currency bot in the night still runs a major and minor update check. If there is a new version, a PR is created for the currencies.json diff.
e.g. for major:
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.15.0", "9.0.0"]
...e.g. for minor
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.16.0"]
...This gives us visibility.
As soon as we merge the PR for the currencies.json, the testedVersions array is updated and the tests run against v9 or 8.16.0 or whatever.
"supportedVersions": ">= 7"
This can be publicly displayed and is the base how to generate the testedVersions array.
There was a problem hiding this comment.
Perfect, this is a great approach!
An alternative approach for https://jsw.ibm.com/browse/INSTA-7722 is to workaround the problems:
Possible ideas:
nohoist([RRFC] Add nohoist option for workspaces npm/rfcs#287) -> problem: peer dependency requirements do not work such as "typeorm requires mssql v10, but we already test against v11 on root".npmis loading the correct dependencyProblems we have to fix: