refactor: removed agent/log.js and move the fn to agent connection#2012
Merged
refactor: removed agent/log.js and move the fn to agent connection#2012
Conversation
kirrg001
commented
Sep 17, 2025
|
|
||
| const payload = Buffer.from(JSON.stringify(payloadObject), 'utf8'); | ||
|
|
||
| const req = http.request( |
Contributor
Author
There was a problem hiding this comment.
It makes 0 sense to have another request handler for the agent requests.
The fn belongs to agentConnection downstreamConnection obj.
This instance is already aware of the agent config host etc.
kirrg001
force-pushed
the
refactor-remove-log-file
branch
from
6503a49 to
00601d7
Compare
Contributor
Author
|
Added test - the functionality was not covered at all |
kirrg001
force-pushed
the
refactor-remove-log-file
branch
from
2c90b9a to
1880330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2010