fix(native-fetch): transmitted span immediately after receiving headers#2265
Merged
aryamohanan merged 1 commit intomainfrom Jan 9, 2026
Merged
fix(native-fetch): transmitted span immediately after receiving headers#2265aryamohanan merged 1 commit intomainfrom
aryamohanan merged 1 commit intomainfrom
Conversation
kirrg001
reviewed
Jan 8, 2026
kirrg001
requested changes
Jan 8, 2026
Contributor
kirrg001
left a comment
kirrg001
left a comment
There was a problem hiding this comment.
Could you please update the PR description and keep finally in the correct syntax as discussed?
Contributor
We drop finally because you can only apply finally on a single handler as you pointed out. We should avoid finally completely. |
kirrg001
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The finally() block was waiting for the entire promise chain to resolve, causing delays in span transimission.
#2022 (comment)