Skip to content

chore: skipped aws dynamodb currency updates#2323

Merged
aryamohanan merged 3 commits intomainfrom
chore-currency-updates
Feb 5, 2026
Merged

chore: skipped aws dynamodb currency updates#2323
aryamohanan merged 3 commits intomainfrom
chore-currency-updates

Conversation

@aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Feb 4, 2026

@aws-sdk/client-dynamodb and @aws-sdk/lib-dynamodb were both listed in currencies.json and were being updated independently. However, @aws-sdk/client-dynamodb is a peer dependency of @aws-sdk/lib-dynamodb.

Because of this, when the currency update job ran, it often failed with an npm peer dependency conflict. In practice, these two packages must be updated simultaneously to the same version.

Currently, updates for these dependencies are being skipped to avoid npm peer dependency conflicts.

reference https://jsw.ibm.com/browse/INSTA-74688

@aryamohanan aryamohanan requested a review from a team as a code owner February 4, 2026 09:29
Copy link
Contributor

@abhilash-sivan abhilash-sivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

});

execSync("git add '*package.json' package-lock.json", { cwd });
execSync(`git commit -m "build: bumped ${packagesToUpdate.join(', ')} to ${targetVersion}"`, { cwd });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: d296ade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline and decided to skip the updates for now, this will be fixed #2306 is merged

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@aryamohanan aryamohanan changed the title chore(currency): handled peer dep updates chore: skipped dynamodb currency updates Feb 5, 2026
@aryamohanan aryamohanan changed the title chore: skipped dynamodb currency updates chore: skipped aws dynamodb currency updates Feb 5, 2026
@aryamohanan aryamohanan merged commit 1526e24 into main Feb 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants