Skip to content

refactor(core): normalized numeric config resolution with env precedence#2430

Merged
aryamohanan merged 6 commits intofix-config-precedencefrom
fix-config-refactor
Mar 26, 2026
Merged

refactor(core): normalized numeric config resolution with env precedence#2430
aryamohanan merged 6 commits intofix-config-precedencefrom
fix-config-refactor

Conversation

@aryamohanan
Copy link
Copy Markdown
Contributor

@aryamohanan aryamohanan commented Mar 26, 2026

ref #2409

This is the first PR

Created a util file for shared config helpers and moved and remaned normalizeSingleValue => resolveNumericConfig to the util file

Refactoring plan

  • Create a util file for shared config helpers and move resolveNumericConfig to the util file
  • Remove deprecated config
  • Replace all inline numeric parsing (parseInt, isNaN) with resolveNumericConfig
  • Extract tests
  • Extract common env parsing logic into util
  • Fix and standardize logging messages and consistent format
  • Remove duplicated parsing/validation logic
  • Normalize boolean handling across config
  • Clean up deprecated env handling (isolate or simplify)
  • Minor other cleanups

@aryamohanan aryamohanan requested a review from a team as a code owner March 26, 2026 09:42
Copy link
Copy Markdown
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend extracting the tests from #2409 as a PR as an early TODO item (I could not see it).
Its okay if some of the tests fail for now on the parent branch.

@sonarqubecloud
Copy link
Copy Markdown

@aryamohanan aryamohanan merged commit 3a6736e into fix-config-precedence Mar 26, 2026
3 checks passed
@aryamohanan aryamohanan added the v6 label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants