Conversation
…ngle interactive object preventing line-by-line navigation VoiceOver in Chrome treats scrollable modal body as a single interactive object, preventing line-by-line navigation in browse mode. This commit adds an aria-label to this to the Modal's body when it has a scrollbar fixing the issue. To test: 1. Create a modal dialog with vertically scrollable content 2. Open modal in Chrome 3. Use VoiceOver browse mode (Control + Option + arrow keys) 4. Attempt to navigate line-by-line within modal body Fixes INSTUI-4900
|
joyenjoyer
approved these changes
Feb 17, 2026
Contributor
joyenjoyer
left a comment
joyenjoyer
left a comment
There was a problem hiding this comment.
Despite being a hack, this is a great solution. I like it, it worked well in Chrome for me.
balzss
approved these changes
Feb 17, 2026
| css={this.props.styles?.modalBody} | ||
| padding={padding} | ||
| // check if there is a scrollbar, if so, the element has to be tabbable | ||
| {...(hasScrollbar |
Contributor
There was a problem hiding this comment.
nitpick but this section could have also been extracted for cleaner jsx
const hasScrollbar = ...
const tabbable = hasScrollbar ? { ...
...
<View
{...tabbable}
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VoiceOver in Chrome treats scrollable modal body as a single interactive object, preventing line-by-line navigation in browse mode. This commit adds an aria-label to this to the Modal's body when it has a scrollbar fixing the issue.
To test:
Fixes INSTUI-4900