Skip to content

fix: reduce timeout for manifest download #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harp-intel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reduce timeout for manifest download #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ func initializeApplication(cmd *cobra.Command, args []string) error {
slog.Debug("Checking for perfspect updates")
updateAvailable, latestManifest, err := checkForUpdates(gVersion)
if err != nil {
slog.Error(err.Error())
slog.Error(fmt.Sprintf("Error while checking for updates: %v", err))
} else if updateAvailable {
fmt.Fprintf(os.Stderr, "A new version (%s) of %s is available!\nPlease run '%s update' to update to the latest version.\n\n", latestManifest.Version, app.Name, app.Name)
} else {
Expand Down Expand Up @@ -471,11 +471,17 @@ type manifest struct {
func getLatestManifest() (manifest, error) {
// download manifest file from server
url := artifactoryUrl + "manifest.json"
resp, err := http.Get(url)
client := &http.Client{
Timeout: 2 * time.Second, // want to timeout relatively quickly if we can't reach the server
}
resp, err := client.Get(url)
if err != nil {
return manifest{}, err
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
return manifest{}, fmt.Errorf("failed to fetch manifest, status: %s", resp.Status)
}
buf := new(bytes.Buffer)
_, err = io.Copy(buf, resp.Body)
if err != nil {
Expand Down