fix: resolve isort, black, and mypy lint in dynamic_profiling_management#1021
Merged
artursarlo merged 1 commit intodynamic_profilingfrom Mar 11, 2026
Merged
Conversation
- isort: fix import order (main.py and dynamic_profiling_management modules) - black: single-line logger in heartbeat.py - mypy: add return/arg types (CommandManager, clear_queues, ProfilerSlotBase, ContinuousProfilerSlot), fix output_dir type for GProfiler, use getattr for maybe_cleanup_subprocesses, add casts and Optional guards in heartbeat.py
artursarlo
approved these changes
Mar 9, 2026
artursarlo
left a comment
artursarlo
left a comment
There was a problem hiding this comment.
LGTM. Pretty straightforward lint fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lint fixes for the
dynamic_profilingbranch so CI (isort, black, flake8, mypy) passes.gprofiler/main.pyand in allgprofiler/dynamic_profiling_managementmodules (alphabetical andtypingorder).logger.infoinheartbeat.pyto a single line within the line-length limit.CommandManager.__init__,clear_queues,ProfilerSlotBase.__init__, andContinuousProfilerSlot.__init__; type forheartbeat_client; ensureoutput_dirpassed toGProfileris astr; callmaybe_cleanup_subprocessesviagetattrso mypy does not require it onGProfiler; inheartbeat.py, addcastfor return values and guardOptional[ProfilingCommand]before use.Related Issue
Motivation and Context
The
dynamic_profilingbranch was failing CI due to isort, black, and mypy errors. These changes bring the branch in line with the project’s lint and type-check rules without changing behavior.How Has This Been Tested?
dev-requirements.txtandrequirements.txt, following the CONTRIBUTING documentation../lint.sh --ciwith the project venv (.venv/bin/activate). Isort, black, flake8, and mypy all pass.Screenshots
N/A
Checklist: