Skip to content

KVM: add max_mem test case#555

Merged
xhao22 merged 2 commits intointel:mainfrom
atlarator:main
Mar 3, 2026
Merged

KVM: add max_mem test case#555
xhao22 merged 2 commits intointel:mainfrom
atlarator:main

Conversation

@atlarator
Copy link
Contributor

No description provided.

@atlarator
Copy link
Contributor Author

It seems that the api vm.get__totalmem_sys() is just used in boot_check.py, and the all_memory testcase doesn't claim a constant value for the size of the memory using in the case, when the assertion about system memory and the parameter memory is used, this case must fail.
Maybe I need the reference for vm object array to decide how to make the assertion works for all these memory cases.
Despite this, lgtm.

@atlarator
Copy link
Contributor Author

RFR

@xhao22
Copy link
Contributor

xhao22 commented Mar 2, 2026

For the 2 commit:
What's the purpose of the 1st: "gitignore: ignore pycache"?
Can you follow the previous new added case, change the commit title to "KVM: add max_mem test case"?

variants:
- 1G:
no 208_cpu, 256_cpu, 288_cpu
is_max_mem = no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need such line, "is_max_mem = no", right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

#
# History: July. 2024 - Xudong Hao - creation

import subprocess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it used? if not, please remove it.

@atlarator atlarator changed the title gitignore: ignore pycache KVM: add max_mem test case Mar 2, 2026
@atlarator
Copy link
Contributor Author

For the 2 commit: What's the purpose of the 1st: "gitignore: ignore pycache"? Can you follow the previous new added case, change the commit title to "KVM: add max_mem test case"?

if not, the default behavior of git will track KVM/qemu/tests/__pycache__ which is generated everytime when avocado runs, as an intermidiate component, it shouldn't be tracked by VCS.

@atlarator
Copy link
Contributor Author

For the 2 commit: What's the purpose of the 1st: "gitignore: ignore pycache"? Can you follow the previous new added case, change the commit title to "KVM: add max_mem test case"?

if not, the default behavior of git will track KVM/qemu/tests/__pycache__ which is generated everytime when avocado runs, as an intermidiate component, it shouldn't be tracked by VCS.

for other scene which python would be byte-compiled, pycache will always be generated so it's necessary to ignore it.

@atlarator
Copy link
Contributor Author

should I squash the two commits as one or leave them separated is OK?

@xhao22
Copy link
Contributor

xhao22 commented Mar 2, 2026

should I squash the two commits as one or leave them separated is OK?

Leave them 2 commits.

@atlarator atlarator force-pushed the main branch 2 times, most recently from 64470a8 to 7eb3581 Compare March 3, 2026 06:26
@xhao22 xhao22 merged commit 685f3b1 into intel:main Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants