Open
Conversation
Contributor
Author
|
@intel/bindless-images-reviewers @intel/llvm-reviewers-runtime please review |
ldorau
approved these changes
Mar 20, 2026
lslusarczyk
approved these changes
Mar 20, 2026
0x12CC
reviewed
Mar 20, 2026
| @@ -1,3 +1,4 @@ | |||
| // TIMEOUT: 600 | |||
Contributor
There was a problem hiding this comment.
Is this documented anywhere? I didn't realize we can set individual test time limits like this and I don't see it used anywhere else.
sarnex
reviewed
Mar 20, 2026
|
|
||
| if config.test_mode == "run-only": | ||
| lit_config.maxIndividualTestTime = 300 | ||
| lit_config.maxIndividualTestTime = 1200 |
Contributor
There was a problem hiding this comment.
im not sure about this, can we not run with lower makeopts on this machines?
fyi @uditagarwal97
Contributor
There was a problem hiding this comment.
+1. If a test takes too long to run, we could instead try to split the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase tests timeout so these tests works on slower machines