[SYCL][test-e2e] Fix off-by-one in atomic_memory_order_seq_cst check loop#21535
Open
zhaomaosu wants to merge 2 commits intointel:syclfrom
Open
[SYCL][test-e2e] Fix off-by-one in atomic_memory_order_seq_cst check loop#21535zhaomaosu wants to merge 2 commits intointel:syclfrom
zhaomaosu wants to merge 2 commits intointel:syclfrom
Conversation
…loop The checked_buf is allocated with dimensions (N_items / 2 * N_iters + 1), and the inner initialization loop correctly iterates up to that bound. However, the outer loop used N_items / 2 * N_iters as its upper bound, leaving the last row of the checked buffer uninitialized. Fix the outer loop bound to match the buffer size and the inner loop bound.
Contributor
Author
|
We're going to update this test because device memory sanitizer reports UUM issue when running this test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checked_buf is allocated with dimensions (N_items / 2 * N_iters + 1), and the inner initialization loop correctly iterates up to that bound. However, the outer loop used N_items / 2 * N_iters as its upper bound, leaving the last row of the checked buffer uninitialized. Fix the outer loop bound to match the buffer size and the inner loop bound.