fix issue with PRIu64 on some compilers, by including sys/types.h early#320
Open
AuxLoui wants to merge 1 commit intointel:mainfrom
Open
fix issue with PRIu64 on some compilers, by including sys/types.h early#320AuxLoui wants to merge 1 commit intointel:mainfrom
AuxLoui wants to merge 1 commit intointel:mainfrom
Conversation
Member
thiagomacieira
left a comment
There was a problem hiding this comment.
Feedback on making commits and making PRs (general, not about this one in particular):
- the commit message should explain why you're making a change. If you have an error message, it's often useful to include it.
- you don't need to explain the what you're changing, because we can read diffs
- the first line of the commit is the "subject" and should be a summary, which we can see in one-line logs (e.g. https://github.com/intel/tinycbor/commits/main/)
- some projects require that you include a signed-off-by footer. We don't insist for TinyCBOR, but I would prefer it is there.
- each commit should be a single, logical/semantic change, which doesn't break the build
- the GitHub PR page is a summary of all commits in the change. If there's only one commit, then just copy the commit message and body (GitHub will do it for you).
Comment on lines
+32
to
+33
| // Include sys/types.h before inttypes.h to work around issue with | ||
| // certain versions of GCC and newlib which causes omission of PRIx64 |
Member
There was a problem hiding this comment.
The comment wasn't necessary. But I'll allow it.
However, is this high enough? Imagine something changes in the headers above and breaks? Especially cbor.h, which includes stdint.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #207 (PRIu64 problem)