compilersupport: fix build with GCC < 11#322
Merged
thiagomacieira merged 1 commit intointel:mainfrom Apr 13, 2026
Merged
Conversation
Commit 45e4641 ("Fix build with GCC < 11: [[fallthrough]] is supported but not allowed in C") introduced a fix for old GCC versions, but commit 91d1c50 ("compilersupport: fix compilation in C23 mode") reverted it, reintroducing the build failure. Revert the revert. Signed-off-by: Florian Larysch <fl@n621.de>
thiagomacieira
approved these changes
Apr 13, 2026
Member
Pretty sure it was an accident. There was a point in time when my copy on disk, shared with Qt, went out of sync with upstream TinyCBOR (both dev and main branches). That's also the reason I decided to finally bite the bullet and release (0.)7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 45e4641 ("Fix build with GCC < 11: [[fallthrough]] is supported but not allowed in C") introduced a fix for old GCC versions, but commit 91d1c50 ("compilersupport: fix compilation in C23 mode") reverted it, reintroducing the build failure.
Revert the revert.
This builds fine with both an old toolchain and a new one when I force C23 (despite the top-level CMakeFile normally forcing it to C99). I'm not sure if this was an intentional change or just an accident?