refactor(nav): split Summit and Foundation headers into sub-components [INTORG-404]#123
Merged
JonathanMatthey merged 4 commits intostagingfrom Apr 17, 2026
Conversation
✅ Deploy Preview for interledger-org-v5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
When this is in you should be un-blocked here #154 |
2397116 to
4fc0fbe
Compare
485d3cb to
04772c8
Compare
01fbb9f to
c1366cc
Compare
61e8cda to
1f09e90
Compare
1f09e90 to
3e85a50
Compare
Anca2022
approved these changes
Apr 17, 2026
Contributor
Anca2022
left a comment
There was a problem hiding this comment.
I made some changes to keep the translation work already done.
I have my doubts whether it's necessary to pass LanguageSwitcher classes as props
Some things are still broken:
- the active highlighting doesn't work (it only works for tech blog, and even there it's incomplete - it doesn't highlight the nav parent item when on a particular tech blog article)
- keyboard navigation doesn't work either - items hidden from view are reachable by tabbing, pressing
ESCor clicking outside the open hamburger menu doesn't close it
But I think those should be handled as part of a different PR
I opened a new issue for those: https://linear.app/interledger/issue/INTORG-629/fix-navigation-on-v5-link-highlighting-and-keyboard-navigation
| > | ||
| <h2 class="sr-only" id="block-interledger-mainnavigation-menu"> | ||
| {t('nav.main')} | ||
| Main Navigation |
Contributor
There was a problem hiding this comment.
Suggested change
| Main Navigation | |
| {t('nav.main')} |
Let's keep translations in place :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SummitHeader.astro(379 lines) andFoundationHeader.astro(333 lines) into focused sub-components with co-located stylessrc/scripts/header-nav.tsHamburgerButtontosrc/components/shared/and sharedMenuItem/MenuGrouptypes tosrc/types/navigation.tsNavMenu,NavActions,HamburgerButton, and a site-specific scriptRelated Issue
INTORG-404
Manual Test
Checks
pnpm run formatpnpm run lintPR Checklist
feat: ...,fix: ...)