Fix editionauthor display by prioritizing work authors#12219
Draft
velmurugan5555 wants to merge 4 commits intointernetarchive:masterfrom
Draft
Fix editionauthor display by prioritizing work authors#12219velmurugan5555 wants to merge 4 commits intointernetarchive:masterfrom
velmurugan5555 wants to merge 4 commits intointernetarchive:masterfrom
Conversation
mekarpeles
reviewed
Apr 1, 2026
Comment on lines
+59
to
+63
| if self.works: | ||
| return self.works[0].get_authors() | ||
|
|
||
| authors = [follow_redirect(a) for a in self.authors] | ||
| return [a for a in authors if a and a.type.key == "/type/author"] |
Member
There was a problem hiding this comment.
this indentation is flat our wrong and shouldn't work which makes be believe this code has not been tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
fix
Technical
Updated Edition.get_authors method to return work authors when available instead of combining work and edition authors. This ensures consistent author data is used for rendering cover alt-text.
Testing
Screenshot
Stakeholders
@cdrini