Fix %IPM.Storage.QualifiedModuleInfo.%OnNew()#1103
Merged
isc-cborbonm merged 14 commits intomainfrom Mar 17, 2026
Merged
Conversation
Fix issue with version properties copying in %IPM.Storage.QualifiedModuleInfo:%New()
isc-dchui
reviewed
Mar 13, 2026
Collaborator
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
Please tag the issue in the description using the magic closing words!
added 9 commits
March 15, 2026 15:21
…into qualifiedModInfo
isc-cborbonm
requested review from
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-eneil
reviewed
Mar 16, 2026
Collaborator
isc-eneil
left a comment
isc-eneil
left a comment
There was a problem hiding this comment.
Left a couple comments @isc-cborbonm !
isc-jili
requested changes
Mar 16, 2026
Collaborator
isc-jili
left a comment
isc-jili
left a comment
There was a problem hiding this comment.
Looks great @isc-cborbonm ! Left some small comments
isc-jili
requested changes
Mar 16, 2026
isc-eneil
requested changes
Mar 17, 2026
isc-kiyer
approved these changes
Mar 17, 2026
isc-jili
approved these changes
Mar 17, 2026
isc-eneil
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1102: %IPM.Storage.QualifiedModuleInfo.%OnNew() will now copy over version related properties